Symon Moderator

 Virtual Cash: 27660
Joined: 04 Sep 2005 Posts: 11052 Location: Hampshire,England Add Karma
 rated by 84 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 5:29 pm Post subject: |
|
|
Well that solved that but i think this is one major bugging mod as there is now another parse error
| Quote: | | Parse error: parse error, unexpected T_STRING in /home/symon/public_html/forum/index.php on line 689 |
So where i have edited it using the codes all seem to incorrect.
I will look for a better solution as i know time is money
| Code: | | ' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>'; |
_________________
http://www.saynoto0870.com/
XXVIII/ I/ MCMLXXI |
|
| Back to top |
|
 |
admin (no pm's please) Site Admin

 Virtual Cash: 42910
Joined: 22 May 2005 Posts: 19348
Add Karma
 rated by 157 members
Add Comment
Show Comments
 |
|
| Back to top |
|
 |
Symon Moderator

 Virtual Cash: 27660
Joined: 04 Sep 2005 Posts: 11052 Location: Hampshire,England Add Karma
 rated by 84 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 5:52 pm Post subject: |
|
|
buggy index
Click to download file
working index before changes made in that mod
Click to download file _________________
http://www.saynoto0870.com/
XXVIII/ I/ MCMLXXI |
|
| Back to top |
|
 |
admin (no pm's please) Site Admin

 Virtual Cash: 42910
Joined: 22 May 2005 Posts: 19348
Add Karma
 rated by 157 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 6:05 pm Post subject: |
|
|
In the new file you have inexplicably:
| Code: |
/*
$last_post .= '<a href="' . append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $forum_data[$j]['forum_last_post_id']) . '#' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
*/
' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
|
compared to the old:
| Code: |
$last_post .= '<a href="' . append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $forum_data[$j]['forum_last_post_id']) . '#' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
|
I think you want to replace that bit which is a mess, with the old code. I can't see instructions for actually changing this bit anyway.
The more I see of this, the more I believe what I have been saying all along about the dangers of applying mods without reading and understanding what each line is actually doing. _________________
Family Friendly Shareware | | Web Design/Services | Free Forums
forum.myfreeforum.org |
|
| Back to top |
|
 |
Symon Moderator

 Virtual Cash: 27660
Joined: 04 Sep 2005 Posts: 11052 Location: Hampshire,England Add Karma
 rated by 84 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 6:15 pm Post subject: |
|
|
| Code: | #
#-----[ FIND ]------------------------------------------
#
$last_post .= '<a href="' . append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $forum_data[$j]['forum_last_post_id']) . '#' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
#
#-----[ REPLACE WITH ]------------------------------------
#
/*
$last_post .= '<a href="' . append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $forum_data[$j]['forum_last_post_id']) . '#' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
*/ |
_________________
http://www.saynoto0870.com/
XXVIII/ I/ MCMLXXI |
|
| Back to top |
|
 |
admin (no pm's please) Site Admin

 Virtual Cash: 42910
Joined: 22 May 2005 Posts: 19348
Add Karma
 rated by 157 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 7:26 pm Post subject: |
|
|
Ok, though I can't easily relate before and after here, but what you have done is stuck an end of comment "*/" half way through a code line.
You may need
| Code: |
/*
$last_post .= '<a href="' . append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $forum_data[$j]['forum_last_post_id']) . '#' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
' . $forum_data[$j]['forum_last_post_id'] . '"><img src="' . $images['icon_latest_reply'] . '" border="0" alt="' . $lang['View_latest_post'] . '" title="' . $lang['View_latest_post'] . '" /></a>';
*/
|
to fully comment out the line. What the mod is all about here is removing excess links from the last_post. _________________
Family Friendly Shareware | | Web Design/Services | Free Forums
forum.myfreeforum.org |
|
| Back to top |
|
 |
Symon Moderator

 Virtual Cash: 27660
Joined: 04 Sep 2005 Posts: 11052 Location: Hampshire,England Add Karma
 rated by 84 members
Add Comment
Show Comments
 |
Posted: Mon Dec 04, 2006 11:53 pm Post subject: |
|
|
| admin wrote: |
The more I see of this, the more I believe what I have been saying all along about the dangers of applying mods without reading and understanding what each line is actually doing. |
I agree i have had nightmares over some mods, viper was kind enough to show me the way at first.
But here is the thing, a new person like me with reasonable brains finds a mod they like the sound of it and download it, now follow the instructions to the letter , double checking that all is what it says it should be.
OK so now i have done it all, goes back to forum to find white pages with parse errors or sql errors ,, you fix one then another appears and so on.
This is where a knowledge of PHP comes in shouts those in the know,, fair call, but when all i have to do is follow a few simple details you would expect it all to work.
It is almost like buying a bunk bed form M(made)F(for)I(idiots) and following the instructions to find it fact they are all wrong and you have the wrong parts.
Sites like www.phpbb.com should throughly test these mods before allowing them to be posted on their site, as to anyone like me there is nothing more annoying than spending the rest of the night trying to find a fix for an error in what is meant to be a working finished mod.
Rant over _________________
http://www.saynoto0870.com/
XXVIII/ I/ MCMLXXI |
|
| Back to top |
|
 |