FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups  Who is OnlineWho is Online   Join! (free) Join! (free)  
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
  • Welcome
  • Guest

  • Open Support Tickets
Wiki forums
Page Previous  1, 2, 3  Next
 
Post new topic   Reply to topic    myfreeforum.org Forum Index -> Forum Blogs
View previous topic :: View next topic  
Author Message
Please Register and Login to this forum to stop seeing this advertising.






Add Karma

rated by members
Add Comment
Show Comments


online/offline
Posted:     Post subject:

Back to top
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 1:02 pm    Post subject:  Reply with quote

Aside from the odd extra line break sneaking in, this is working quite well.

Just the Delete code to do now.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 1:26 pm    Post subject: Reply with quote

Ah, spoke a bit too soon. When more than a single page of edits have happened things go screwy. I was half expecting that though.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 5:09 pm    Post subject: Reply with quote

Finally pagination seems to work, amazing the permutations you can get in that sort of code  

Deletion will be pretty interesting to   But touch would I will get that done tomorrow and actually release this Saturday. I reckon it will be a great addition, and what is more the first live use of web2.0 on the forums.

phpbb3 does not use it at all that I know of, we use it a lot in the admin panel additions and I always planned to use it on the forums in general.  But phpbb2 is not really designed that way and I simply had not see the opportunity for it until now.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 5:50 pm    Post subject: Reply with quote



This is a little annoying, if you look at the screenshot carefully, you see what is shown whilst technically correct is really rather stupidly wrong in this instance

However this is a case of "tough"   Rather like we don't much around trying to fix phpbb3 bugs in areas where they are actively developing the code, this part of the Wiki code uses the well established PEAR Text_Diff library and this is under active development. In fact it is a coin toss whether this bug would be in the version on the live servers at all.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 7:15 pm    Post subject: Reply with quote

ah, doing the diff at the character level does improve results

I am also dithering on delete. The wiki edits are an audit trail. If you delete an edit midway it is possible to make it consistent but it then in effect lies about what happened. It only really makes sense to allow the final edit to be deleted, e.g. rolling back sequentially.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 7:32 pm    Post subject: Reply with quote

Okay we now have the following display modes:

Normal

Will show the raw post text with differences to the previous post highlighted, additions in green, subtractions in red, and the somewhat odd simply seen to be changed as yellow.


Differences

Only show the green, red and yellow bits. e.g. collapse to just the changes made.

Additions

show green and yellow

Subtractions

Show red and yellow

Unformatted

Show the post without any of the changes.

Formatted

Show the formated post, e.g. process the bbcodes and smilies.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Thu Aug 06, 2009 8:48 pm    Post subject: Reply with quote

As an aside to the above I am always showing html in unformatted form. I don't think most Wikis want to cope with html as the mark up language either.

html will work with the wikis, but the difference views will struggle.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 10:53 am    Post subject: Reply with quote

The Wiki delete function now seems to be working okay, though I have yet to check out whether permissions are doing their job.

Took me a while to decide whether to modify posting.php to deal with wikis or to copy it to a new file and strip it to just what is needed to deal with wikis. Doing the latter was clearly the right way to go.

I must also tweak modcp.php though, so that a topic delete clears wiki edits.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 11:41 am    Post subject: Reply with quote

That all seems to be working okay.

But I have seen more anomalies on the formatted view.

That is the web2.0 thing that attempts to show the formatted post by deriving it from the unformatted information available.

I think this is probably too tall an order So much gets translated backwards and forwards that something is always going to screw up somewhere.

I think we go back and do it the right way.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 1:05 pm    Post subject: Reply with quote

Yes, it may have been another 150 lines of code, but it has got to be better

In principle the Wiki code is now complete
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 2:21 pm    Post subject: Reply with quote

I have fixed a few little wibbles in the formatted text returned via web 2.0. I guess just about any odd character is prone to getting translated at various points down the line. I think by and large we can deal with these issues as they arise. Afterall the Wiki audit trail view mode which is what we are talking about here is purely cosmetic. If there is a bit of an issue viewing how an topic looked in a past edit, then all it is, is a bit annoying.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 5:01 pm    Post subject: Reply with quote

Things are still testing out okay.

I was wondering though about the possibility of comments/annotations? To some degree though this needs to be managed within the forum itself. e.g. people can discuss editing the topic in the replies to the WIKI topic. If there is a need to have parallel discussions e.g. one by authors and one by punters commenting on the article, then there really should be two forums one where articles are authored and one to which periodically an edited article is copied across.

As for the idea of comments/annotations in general I think I'd want to see how the need develops. Technically it is a bit of an issue in that if I wanted to store such things in the same record as the wiki edits I'd need to restructure things, storing elsewhere will mean a small performance hit. On balance though I think the hit is worth taking. The wiki edit record are an audit trail. The more you cram into the record then the more likely it is a bug with disrupt that audit trail.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 8:18 pm    Post subject: Reply with quote

I am still finding the odd thing to tweak here, things that are not unimportant.

I may have to think long and hard about whether to release this tomorrow. It is one hell of an addition to the feature set and there really is no pressing need to go from idea to release in 5 days.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Fri Aug 07, 2009 8:59 pm    Post subject: Reply with quote

I think that settles it, in fixing one of the little issues I blew the wiki edit trail, and that fact took a little while to show up. A simple bug, but a sound warning that this needs just a bit more patience.

As it is fixing the bug has probably broken the fix.
_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
myff admin
Site Admin
Site Admin
FLAG

Virtual Cash: 92890

Joined: 22 May 2005
Posts: 32203



Add Karma

rated by 281 members
Add Comment
Show Comments


online/offline
PostPosted: Sat Aug 08, 2009 8:50 am    Post subject: Reply with quote

Found another little bug, but back in theory to all being fixed.

One of the issues is around marking who has edited the post last. The phpbb2 code seems kind of broken to me In practice it will work because of the way things are set to only list how many times a user has edited their own post, and not who else has edited it. Move outside of those boundaries, and that is clearly intended as being possible and it is flawed.
I have left it as is for non wiki forums, as I want minimum disruption here.

At least now I have another week to look at more features.


_________________

Family Friendly Shareware | | Web Design/Services | Free Forums
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    myfreeforum.org Forum Index -> Forum Blogs All times are GMT
Page Previous  1, 2, 3  Next
Page 2 of 3
 
 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

Card File  Gallery  Forum Archive
Powered by phpBB © 2001, 2005 phpBB Group
Create your own free forum | Buy a domain to use with your forum